Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python][sklearn] Allow non-serializable objects in callbacks argument #4723

Merged
merged 1 commit into from
Oct 27, 2021
Merged

[python][sklearn] Allow non-serializable objects in callbacks argument #4723

merged 1 commit into from
Oct 27, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Fixed #4719.

@StrikerRUS StrikerRUS added the fix label Oct 26, 2021
@StrikerRUS StrikerRUS changed the title Allow non-serializable objects in callbacks argument [python][sklearn] Allow non-serializable objects in callbacks argument Oct 26, 2021
jameslamb
jameslamb approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

I think we should have a follow-up PR at some point in the future adding a test that uses a non-serializable callback, just to be sure this behavior isn't accidentally broken by future refactorings.

@StrikerRUS StrikerRUS merged commit 311017a into master Oct 27, 2021
@StrikerRUS StrikerRUS deleted the python_callbacks branch October 27, 2021 00:04
@StrikerRUS StrikerRUS mentioned this pull request Oct 29, 2021
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@chivee chivee Awaiting requested review from chivee

@henry0312 henry0312 Awaiting requested review from henry0312

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[python] Neptune LightGBM callback yields an error with the new logic introduced in v3.3.0
2 participants
@StrikerRUS @jameslamb